[RHCLOUD-28663] Add a query parameter to links in Events emitted by Notifications #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
from
d53bb4d to
d860b77
Compare
|
@jessicarod7 , according Jira's comments, we could also add the integration type, I think "just" updating qute templates when they are available should be fine. |
|
Ah, I missed that comment. I'll see what I can do tomorrow. |
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
5 times, most recently
from
fc3aa38 to
f6eee6f
Compare
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
from
f6eee6f to
5c7bad4
Compare
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
3 times, most recently
from
63090e9 to
ee00177
Compare
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
from
ee00177 to
e7e1c71
Compare
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
from
e7e1c71 to
3702aa0
Compare
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
from
afc3ef5 to
15fe850
Compare
jessicarod7
force-pushed
the
RHCLOUD-28663
branch
from
d6dc4d2 to
4798475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue
https://issues.redhat.com/browse/RHCLOUD-28663
Description
Important
Merge after #3221 and #3229.
This builds on RHCLOUD-22813, and adds a new query parameter
?from=notificationsto the two URLs generated byInsightsUrlBuilder:data.inventory_urldata.application_urlThis change will affects URLs in integrations via Camel (Slack, Microsoft Teams, Google Chat) and PagerDuty.
Testing